Skip to content

CC-45: Tournament Tabs do not Fill Screen#324

Merged
ianpaschal merged 1 commit into
mainfrom
ian/cc-45-tournament-tabs-do-not-fill-screen
May 9, 2026
Merged

CC-45: Tournament Tabs do not Fill Screen#324
ianpaschal merged 1 commit into
mainfrom
ian/cc-45-tournament-tabs-do-not-fill-screen

Conversation

@ianpaschal
Copy link
Copy Markdown
Owner

@ianpaschal ianpaschal commented May 9, 2026 •
edited by coderabbitai Bot
Loading

Fixes CC-45

Summary by CodeRabbit

  • Style
    • Improved layout behavior of the tournament details tabs component to ensure proper content display and overflow handling.

Review Change Stack

@vercel
Copy link
Copy Markdown

vercel Bot commented May 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
combat-command Error Error May 9, 2026 7:30pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e72bc8f1-8f7c-4e89-8136-3c1a53bdcf04

📥 Commits

Reviewing files that changed from the base of the PR and between 8299829 and 9be9ef5.

📒 Files selected for processing (1)
  • src/pages/TournamentDetailPage/TournamentDetailPage.module.scss

Walkthrough

The pull request modifies the TournamentDetailPage SCSS module file to add a single CSS styling rule. Within the &_TabsList container selector, a new nested rule targets the first direct child element (> *:first-child) and applies flex: 1 and min-width: 0 properties. These properties ensure the first child element expands to fill available space within the flex container while maintaining proper text overflow and shrinking behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and incomplete, lacking the required issue reference format and missing context about the changes made. Expand description to follow the template format with 'Resolves: #45' and add details about the CSS changes and their purpose.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the issue being fixed (CC-45) and describes the specific problem: tournament tabs not filling the screen width.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ian/cc-45-tournament-tabs-do-not-fill-screen

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Stylelint (17.10.0)
src/pages/TournamentDetailPage/TournamentDetailPage.module.scss

ConfigurationError: Could not find "stylelint-config-clean-order". Do you need to install the package or use the "configBasedir" option?
at getModulePath (file:///usr/local/lib/node_modules/stylelint/lib/utils/getModulePath.mjs:29:9)
at loadExtendedConfig (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:280:21)
at extendConfig (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:247:25)
at async augmentConfigBasic (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:84:20)
at async augmentConfigFull (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:137:24)
at async getConfigForFile (file:///usr/local/lib/node_modules/stylelint/lib/getConfigForFile.mjs:102:26)
at async resolveOptionValue (file:///usr/local/lib/node_modules/stylelint/lib/utils/resolveOptionValue.mjs:27:24)
at async standalone (file:///usr/local/lib/node_modules/stylelint/lib/standalone.mjs:127:22)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ianpaschal ianpaschal merged commit 1aa34c5 into main May 9, 2026
3 of 4 checks passed
@ianpaschal ianpaschal deleted the ian/cc-45-tournament-tabs-do-not-fill-screen branch May 9, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ianpaschal